Update code from reviewer's suggestion.

Co-authored-by: Max Halford <maxhalford25@gmail.com>
online-ml · Oct 30, 2023 · 216b2e0 · 216b2e0
1 parent c39299a
commit 216b2e0
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/river/stats/kolmogorov_smirnov.py b/river/stats/kolmogorov_smirnov.py
@@ -277,8 +277,10 @@ def get(self):
 
         if self.statistic == "ks":
             return max(self.treap.max_value, -self.treap.min_value) / self.n_samples
-        else:
+        elif self.statistic == "kuiper":
             return max(self.treap.max_value - self.treap.min_value) / self.n_samples
+        else:
+            raise ValueError(f"Unknown statistic {self.statistic}, expected one of: ks, kuiper")
 
     def test_ks_threshold(self, ca):
         """