Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: LOF with QuantileFilter raises IndexError #1330

Merged
merged 8 commits into from
Oct 10, 2023
Merged

FIX: LOF with QuantileFilter raises IndexError #1330

Changes from 3 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
eaae52b
FIX: LOF with QuantileFilter raises IndexError
MarekWadinger Oct 3, 2023
63fc9b1
FIX: score_one changes internal state of LOF
MarekWadinger Oct 3, 2023
4df36df
FIX: black refactor
MarekWadinger Oct 3, 2023
26b990e
Update initial score in LOF
MarekWadinger Oct 10, 2023
f33e3ca
Add tests for stateless score_one and fix doctest
MarekWadinger Oct 10, 2023
866d275
Minor line length fix
MarekWadinger Oct 10, 2023
d694454
Merge branch 'main' into main
MarekWadinger Oct 10, 2023
592efb5
Add LOF fixtures to release notes
MarekWadinger Oct 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 11 additions & 9 deletions river/anomaly/lof.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
from __future__ import annotations

import copy
import functools

import pandas as pd
Expand Down Expand Up @@ -342,10 +343,11 @@ def score_one(self, x: dict):
self.x_scores.append(x)
self.x_scores, equal = check_equal(self.x_scores, self.x_list)

if len(self.x_scores) == 0:
return None
if len(self.x_scores) == 0 or len(self.x_list) == 0:
return 0.5
MarekWadinger marked this conversation as resolved.
Show resolved Hide resolved

x_list_copy = self.x_list.copy()

(
nm,
x_list_copy,
Expand All @@ -359,13 +361,13 @@ def score_one(self, x: dict):
) = expand_objects(
self.x_scores,
x_list_copy,
self.neighborhoods,
self.rev_neighborhoods,
self.k_dist,
self.reach_dist,
self.dist_dict,
self.local_reach,
self.lof,
self.neighborhoods.copy(),
self.rev_neighborhoods.copy(),
self.k_dist.copy(),
copy.deepcopy(self.reach_dist),
copy.deepcopy(self.dist_dict),
self.local_reach.copy(),
self.lof.copy(),
)

neighborhoods, rev_neighborhoods, k_dist, dist_dict = self._initial_calculations(
Expand Down
Loading