DBSTREAM fix (related to issue #1324) #1336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… 2 of the paper by Hashler and Bolanos to allow clusters with low weight removed.
… recluster is called.
…icro clusters, or indexed as 0 if the list of micro clusters is still empty.
|
Good job @hoanganhngo610. Can you add the relevant entries to UNRELEASED.md? |
|
@MaxHalford Thank you so much Max! Will do! |
|
@MaxHalford UNRELEASED.md entries added! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes multiple issues proposed in issue #1324 by @donny741, with the following changes:
-sign before thefading_factorin accordance with the algorithm 2 proposed by Hashler and Bolanos to allow clusters with low weights to be removed.micro_clusteris added with the key derived from the maximum key of the existing micro clusters. If the set of micro clusters is still empty (len = 0), a new micro cluster is added with key0.cluster_is_up_to_dateis set toTrueat the end of theself._recluster()function.