Fixes #1248 #1337
Merged
Fixes #1248 #1337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a rather cryptic bug that was really difficult to track down.
Thank you @FedericoMz for providing the reproducible example, I would never find the culprit without that.
In the end, the problem was not in EFDT but in the splitter used in nominal attributes. It previously used
collection.defaultdictobjects in an attempt to simplify and speed up the code.However, during prediction actions (such as
predict_proba_oneanddebug_one) if thecollection.defaultdictin the splitter was checked for the existence of a previously non-observed branch, the missing value would be inadvertently created.This created a mismatch between the number of existing and tracked tree branches.
This bug could potentially affect other trees, but was really hard to come by.