dbstream: fix adjacency matrix building #1340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
donny741
requested review from
hoanganhngo610,
Dennis1989,
MaxHalford and
smastelini
as code owners
MaxHalford
approved these changes
Oct 15, 2023
Co-authored-by: Max Halford <maxhalford25@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is possible for the microcluster (
mc) to be removed, but for the shared density graph entry (Sij) associated with that microcluster to remain because:Sijisα(a.k.a.intersection_factor) times lower than the threshold for removing amc;Sijwhenmcis removed.This introduces a
KeyErrorduring theweighted_adjacency_matrixbuilding step when looking up removedmc. Adding atryblock to account for that