Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pyproject.toml #1533

Merged
merged 2 commits into from
Apr 25, 2024
Merged

Update pyproject.toml #1533

merged 2 commits into from
Apr 25, 2024

Conversation

PabloRuizCuevas
Copy link
Contributor

Changed python requirements,

The current setup is correct in a very strict sense, but it enforces the users of the library that uses poetry to have also this type of strict requirements and is unpractical.

For instance I had python = "^3.11" in my requirements which is also perfectly correct for my code as python 3.13 is still not in public release and even when is released is still most likely compatible.

When you do "poetry add river", If you put python = "^3.11" then you get:

Because no versions of river match >0.21.1,<0.22.0
 and river (0.21.1) requires Python <3.13,>=3.9, river is forbidden.
So, because pytrade depends on river (^0.21.1), version solving failed.

Notice that this is the only package in a long list of dependencies that made me change my own toml python version.

I suggest to relax the requirements, as I don't think that preventing future python versions makes much sense, also if I want tomorrow to test the beta test python 3.13 I will get this issue again.

Other topic would be if a current version, already released in python is not working, then I would let the stricter requirements.

Changed python requirements, if the future constrain is there other project with less strict requirements will fail to install river,

for instance i have in my pyproject.toml python = "^3.11" and fails with "requires Python <3.13,>=3.9, river is forbidden."
@MaxHalford
Copy link
Member

Hey there. Did you try running poetry lock with this change? For me it doesn't work because of SciPy.

Screenshot 2024-04-25 at 00 54 09

pyproject.toml Outdated Show resolved Hide resolved
@MaxHalford MaxHalford merged commit 81401ce into online-ml:main Apr 25, 2024
1 of 4 checks passed
@MaxHalford
Copy link
Member

Perfect, thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants