Add ODAC (Online Divisive-Agglomerative Clustering) algorithm #1536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smastelini
requested changes
Apr 29, 2024
There was a problem hiding this comment.
Thank you so much, @Bezum30, for the PR!
I left the first note in the review. My time is a bit scarce now, but I intend to check the code soon
river/cluster/odac.py
Outdated
|
|
||
| >>> model = ODAC(confidence_level=0.9, n_min=50) | ||
|
|
||
| >>> dataset = iter_csv("four_cluster_dataset.csv") |
There was a problem hiding this comment.
Hi @Bezum30, we need to use another dataset for the tests. Maybe you can take a look at datasets or datasets.synth.
There was a problem hiding this comment.
That ought to be the main reason why the tests are failing.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi everyone 👋🏻
Here is the proposal for the implementation of the ODAC algorithm. Some time ago, I already started a discussion about this implementation, which is focused on the explanation in:
This algorithm was evaluated on Artificial Data, presented in the paper mentioned before (in Section 4.2.1). It was created three files: closed_dataset.csv, two_cluster_dataset.csv, and four_cluster_dataset.csv.
Thanks!