Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove mention of former compat modules #1588

Merged
merged 2 commits into from
Aug 16, 2024

Conversation

e10e3
Copy link
Contributor

@e10e3 e10e3 commented Aug 16, 2024

There were still lingering references to deleted modules from river/compat.

Closes #1587

@e10e3 e10e3 marked this pull request as ready for review August 16, 2024 17:54
Copy link
Member

@gbolmier gbolmier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @e10e3! LGTM ✅

@gbolmier gbolmier merged commit b5e6fea into online-ml:main Aug 16, 2024
4 checks passed
@e10e3 e10e3 deleted the remove-reference-old-compat branch August 22, 2024 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

River tries to import the inexistent module compat.pytorch
2 participants