Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP]Replace authManager with IAuthenticationInformation #142

Closed
wants to merge 1 commit into from
Closed

[WIP]Replace authManager with IAuthenticationInformation #142

wants to merge 1 commit into from

Conversation

mtutynina
Copy link
Contributor

resolve #137

kant2002
kant2002 requested changes Mar 29, 2018
View reviewed changes
Copy link
Contributor

@kant2002 kant2002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don’t create instance of AuthManager in the TableManager. We still have single instance of AuthManager class, but it will be created by explicitly by App. In the meanwhile we will use authManager.

js/table/tableview.ts
@@ -2884,7 +2885,7 @@ export class TableView {
if (p.PlayerId() === playerId) {
const saveMask = 16;
p.Status(status | (p.Status() & saveMask));
if (playerId === authManager.loginId()) {
if (playerId === self.authInformation.loginId()) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don’t add any new reference to self. Use this and change functions to arrow style

@mtutynina mtutynina closed this Mar 29, 2018
@mtutynina mtutynina deleted the task-137 branch March 29, 2018 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kant2002 kant2002 kant2002 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace authManager with IAuthenticationInformation
2 participants
@mtutynina @kant2002