Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove development files from NPM package #26

Merged
merged 1 commit into from
Aug 31, 2022
Merged

Conversation

jorrit
Copy link

@jorrit jorrit commented Aug 23, 2022

Some of the files that end up in node_modules/bonjour-service are not needed at runtime, so they can be omitted from the package.
Whether to omit examples is a bit debatable: users that use bonjour-service directly probably would like them, but when bonjour-service is installed as a subdependency it will just be a waste of bytes.

Thanks for your consideration!

@mdidon
Copy link
Member

mdidon commented Aug 30, 2022

@jorrit Agreed. Many thanks

@mdidon mdidon merged commit 009a753 into onlxltd:master Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants