Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increment to v1.1.9 while still perserving v1.1.8 on macOS 10.15 #26

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

philipyoungg
Copy link

@philipyoungg philipyoungg commented May 9, 2024

As per issue on #25

Due to breaking change on commit 53c895b453c5476b673d2498d8edbe349ced72e7:
• where now minimum version is macOS 12.0
• but podspec still 1.1.8,

I reverted the commit to 99faa08 and reverted it back to 57d552a + increment the version to 1.1.9.

This make sure that:

  • Commit unchanged, history are still there,
  • 1.1.8 still works on macOS 10.15,
  • This package correctly incremented to 1.1.9.
commit 6d017c12268bfa9afbd06d2769841a7d935926b0 (HEAD -> master, origin/master, origin/HEAD)
Author: Philip Young <philip.young.gunawan@gmail.com>
Date:   Thu May 9 22:18:10 2024 +0700

    revert to 53c895b453c5476b673d2498d8edbe349ced72e7 + increment podspec to 1.1.9

commit 57d552af2c4869eb9d98dd066d86faf67533b2e8
Author: Philip Young <philip.young.gunawan@gmail.com>
Date:   Thu May 9 22:14:10 2024 +0700

    revert to 99faa084b55405562018bb34f426a30c8eeaac30

commit 53c895b453c5476b673d2498d8edbe349ced72e7
Author: Khoa Pham <onmyway133@gmail.com>
Date:   Sun Jan 21 21:14:18 2024 +0100

    Support visionOS

commit 99faa084b55405562018bb34f426a30c8eeaac30
Author: Khoa <onmyway133@gmail.com>
Date:   Sun Jan 21 21:09:24 2024 +0100

    Update README.md

@onmyway133 onmyway133 added the enhancement New feature or request label May 10, 2024
@onmyway133 onmyway133 self-assigned this May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants