-
Notifications
You must be signed in to change notification settings - Fork 335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update llvm to e5d5146323ffaa13eb5185616c6ae5c36b69352d #1628
Update llvm to e5d5146323ffaa13eb5185616c6ae5c36b69352d #1628
Conversation
Signed-off-by: Tung D. Le <tung@jp.ibm.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
If possible, in the future, would it be possible to keep the llvm related update clean of other unrelated onnx-mlir cleanup/changes, it would make reviewing easier. Tx
Jenkins Linux s390x Build #7082 [push] Update llvm to e5d514632... started at 12:09 |
Jenkins Linux amd64 Build #7067 [push] Update llvm to e5d514632... started at 11:09 |
Jenkins Linux ppc64le Build #6175 [push] Update llvm to e5d514632... started at 12:11 |
Jenkins Linux amd64 Build #7067 [push] Update llvm to e5d514632... passed after 2 hr 9 min |
Jenkins Linux ppc64le Build #6175 [push] Update llvm to e5d514632... passed after 2 hr 31 min |
Jenkins Linux s390x Build #7082 [push] Update llvm to e5d514632... passed after 2 hr 44 min |
Changes here were because of the changes in LLVM only, for example LLVM replaced I looks like this LLVM commit id failed to compile on MacOs. |
@gongsu832 mentioned during our last meeting that the failure on MacOS was due to a mismatch of python. Is the fix already in? If so, this might be a new failure. |
I guess the python mismatch issue was solved with this PR #1616. @sorenlassen memtioned that this LLVM commit |
This updates LLVM to a green commit:
This update is to include a fix for memref normalization where non-normalizable operations with identity map layouts blocked normalization of the entire function: llvm/llvm-project@183c4a3
Signed-off-by: Tung D. Le tung@jp.ibm.com