Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update llvm to e5d5146323ffaa13eb5185616c6ae5c36b69352d #1628

Merged
merged 3 commits into from
Aug 23, 2022

Conversation

tungld
Copy link
Collaborator

@tungld tungld commented Aug 23, 2022

This updates LLVM to a green commit:

Week of 8/22/2022:
Green LLVM commit: e5d5146323ffaa13eb5185616c6ae5c36b69352d
Green MHLO commit: ace4030dd55fce2a74e46f71f1937feb61ed1e3f (branch greencommit/2022-08-22-e5d51463)

This update is to include a fix for memref normalization where non-normalizable operations with identity map layouts blocked normalization of the entire function: llvm/llvm-project@183c4a3

Signed-off-by: Tung D. Le tung@jp.ibm.com

Signed-off-by: Tung D. Le <tung@jp.ibm.com>
Copy link
Collaborator

@AlexandreEichenberger AlexandreEichenberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
If possible, in the future, would it be possible to keep the llvm related update clean of other unrelated onnx-mlir cleanup/changes, it would make reviewing easier. Tx

@AlexandreEichenberger AlexandreEichenberger merged commit a9767f3 into onnx:main Aug 23, 2022
@jenkins-droid
Copy link
Collaborator

Jenkins Linux s390x Build #7082 [push] Update llvm to e5d514632... started at 12:09

@jenkins-droid
Copy link
Collaborator

Jenkins Linux amd64 Build #7067 [push] Update llvm to e5d514632... started at 11:09

@jenkins-droid
Copy link
Collaborator

Jenkins Linux ppc64le Build #6175 [push] Update llvm to e5d514632... started at 12:11

@jenkins-droid
Copy link
Collaborator

Jenkins Linux amd64 Build #7067 [push] Update llvm to e5d514632... passed after 2 hr 9 min

@jenkins-droid
Copy link
Collaborator

Jenkins Linux ppc64le Build #6175 [push] Update llvm to e5d514632... passed after 2 hr 31 min

@jenkins-droid
Copy link
Collaborator

Jenkins Linux s390x Build #7082 [push] Update llvm to e5d514632... passed after 2 hr 44 min

@tungld
Copy link
Collaborator Author

tungld commented Aug 24, 2022

Changes here were because of the changes in LLVM only, for example LLVM replaced AbsOp by AbsFOp and added AbsIOp, so we had to change code related to AbsOp to make onnx-mlir works. I am sorry for not explaining about AbsOp.

I looks like this LLVM commit id failed to compile on MacOs.

@AlexandreEichenberger
Copy link
Collaborator

@gongsu832 mentioned during our last meeting that the failure on MacOS was due to a mismatch of python. Is the fix already in? If so, this might be a new failure.

@tungld
Copy link
Collaborator Author

tungld commented Aug 24, 2022

I guess the python mismatch issue was solved with this PR #1616. @sorenlassen memtioned that this LLVM commit 59548fe873d8d98e359fb21fbb2a0852fed17ff5 will fix the current MacOS issue, so I tried it with PR #1630, and it worked. It's better to move to 59548fe873d8d98e359fb21fbb2a0852fed17ff5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants