Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update LLVM/MHLO for Week of 10/31/2022 #1827

Merged
merged 15 commits into from
Nov 11, 2022
Merged

Update LLVM/MHLO for Week of 10/31/2022 #1827

merged 15 commits into from
Nov 11, 2022

Conversation

chenchongsong
Copy link
Contributor

@chenchongsong chenchongsong commented Nov 3, 2022 •
edited
Loading

Green LLVM commit: 74fb770de9399d7258a8eda974c93610cfde698e
Green MHLO commit: 2341f70343a5361d4611557c2af9d24b01aa427e

The commits listed above are the latest Green commits.
We wish to apply these two commits to all frontends internally in ByteDance (e.g. onnx, torch, tensorflow)

Changelog:

  • Change NoSideEffect trait to Pure
  • Add workaround for missing mhlo dependency (StablehloAssemblyFormat & StablehloTypeInference)
  • Use RankedTensor instead of Vector for the attributes of mhlo::ReduceWindowOp

PR for mhlo to fix dependencies: tensorflow/tensorflow#58477

@chenchongsong
Update LLVM/MHLO
102d868 
Signed-off-by: chongsong.chen <chongsong.chen@bytedance.com>
@chenchongsong
Changes NoSideEffect to Pure in docs
0b1f352 
Signed-off-by: chongsong.chen <chongsong.chen@bytedance.com>
@chenchongsong
Update MhloDialet deps
b5d9a55 
Signed-off-by: chongsong.chen <chongsong.chen@bytedance.com>
@chenchongsong
update mhlo to green commit: 2341f70343a5361d4611557c2af9d24b01aa427e
4d90652 
Signed-off-by: chongsong.chen <chongsong.chen@bytedance.com>
@jenkins-droid
Copy link
Collaborator

Can one of the admins verify this patch?

@gongsu832
Copy link
Collaborator

@jenkins-droid test this please

@chenchongsong
Fixes nppa lit
050ecb1 
Signed-off-by: chongsong.chen <chongsong.chen@bytedance.com>
@jenkins-droid
Copy link
Collaborator

Can one of the admins verify this patch?

@gongsu832
Copy link
Collaborator

@jenkins-droid test this please

@chenchongsong
Adds StablehloBase as StablehloTypeInference's dependency
2d5d2db 
Signed-off-by: chongsong.chen <chongsong.chen@bytedance.com>
@jenkins-droid
Copy link
Collaborator

Can one of the admins verify this patch?

@gongsu832
Copy link
Collaborator

@jenkins-droid test this please

@chenchongsong
Copy link
Contributor Author

chenchongsong commented Nov 4, 2022 •
edited
Loading

@gongsu832 @tungld
Thanks! Seems that the Jenkins job was aborted. May I have the Jenkins jobs run again?
There is another issue related to "GitHub Action MacOS amd64 / build". I found import onnx error for all recent PRs. Not sure what causes that.

@gongsu832
Copy link
Collaborator

The jobs are still running, just the status hasn't been updated yet.

@jenkins-droid
Copy link
Collaborator

Can one of the admins verify this patch?

@tungld
Copy link
Collaborator

tungld commented Nov 8, 2022

@jenkins-droid test this please

sstamenova
sstamenova approved these changes Nov 8, 2022
View reviewed changes
Copy link
Collaborator

@sstamenova sstamenova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chenchongsong
Copy link
Contributor Author

@tungld @gongsu832 Could you help to merge this PR? Thanks so much~

@jenkins-droid
Copy link
Collaborator

Can one of the admins verify this patch?

@sstamenova
Copy link
Collaborator

@jenkins-droid test this please

@chenchongsong
NoSideEffect -> Pure fix
d77fd7c 
Signed-off-by: chongsong.chen <chongsong.chen@bytedance.com>
@jenkins-droid
Copy link
Collaborator

Can one of the admins verify this patch?

@sstamenova
Copy link
Collaborator

@jenkins-droid test this please

@jenkins-droid
Copy link
Collaborator

Can one of the admins verify this patch?

@gongsu832
Copy link
Collaborator

@jenkins-droid test this please

@sstamenova sstamenova merged commit 466012f into onnx:main Nov 11, 2022
@jenkins-droid
Copy link
Collaborator

Jenkins Linux s390x Build #8576 [push] Update LLVM/MHLO for Wee... started at 15:22

@jenkins-droid
Copy link
Collaborator

Jenkins Linux ppc64le Build #7627 [push] Update LLVM/MHLO for Wee... started at 15:24

@jenkins-droid
Copy link
Collaborator

Jenkins Linux amd64 Build #8560 [push] Update LLVM/MHLO for Wee... started at 14:22

@jenkins-droid
Copy link
Collaborator

Jenkins Linux amd64 Build #8560 [push] Update LLVM/MHLO for Wee... passed after 2 hr 0 min

@jenkins-droid
Copy link
Collaborator

Jenkins Linux s390x Build #8576 [push] Update LLVM/MHLO for Wee... passed after 2 hr 14 min

@jenkins-droid
Copy link
Collaborator

Jenkins Linux ppc64le Build #7627 [push] Update LLVM/MHLO for Wee... passed after 2 hr 37 min

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sstamenova sstamenova sstamenova approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@chenchongsong @jenkins-droid @gongsu832 @tungld @sstamenova @AlexandreEichenberger