Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix f16 onnx.BatchNormalizationInferenceMode canonicalization #2512

Merged
merged 3 commits into from
Sep 17, 2023

Conversation

sorenlassen
Copy link
Member

@sorenlassen sorenlassen commented Sep 16, 2023

new lit test test_rewrite_batchnormtestmode_1d_f16 crashed in createDenseElementsAttrFromFloatAttr because DenseElementsAttr::get(t, apfloat) wants apfloat to have the semantics of t's element type

createDenseElementsAttrFromFloatAttr was called on the result element type and $epsilon in the RewriteBatchNormInferenceModeConvPattern1 pattern

Signed-off-by: Soren Lassen <slassen@groq.com>
Copy link
Member

@philass philass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this fix

@sorenlassen sorenlassen merged commit 5aca454 into onnx:main Sep 17, 2023
7 checks passed
@sorenlassen sorenlassen deleted the slassen/batchnorm_f16 branch September 17, 2023 22:04
@jenkins-droid
Copy link
Collaborator

Jenkins Linux s390x Build #12719 [push] fix f16 onnx.BatchNormal... started at 18:05

@jenkins-droid
Copy link
Collaborator

Jenkins Linux amd64 Build #12696 [push] fix f16 onnx.BatchNormal... started at 17:05

@jenkins-droid
Copy link
Collaborator

Jenkins Linux ppc64le Build #11712 [push] fix f16 onnx.BatchNormal... started at 18:15

@jenkins-droid
Copy link
Collaborator

Jenkins Linux s390x Build #12719 [push] fix f16 onnx.BatchNormal... passed after 1 hr 22 min

@jenkins-droid
Copy link
Collaborator

Jenkins Linux amd64 Build #12696 [push] fix f16 onnx.BatchNormal... failed after 1 hr 23 min

@jenkins-droid
Copy link
Collaborator

Jenkins Linux ppc64le Build #11712 [push] fix f16 onnx.BatchNormal... passed after 1 hr 48 min

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants