-
Notifications
You must be signed in to change notification settings - Fork 320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle the options passed to llvm opt and llvm llc #2955
Conversation
Signed-off-by: chentong319 <chentong@us.ibm.com>
Look like |
Signed-off-by: chentong319 <chentong@us.ibm.com>
That's true. The only difference is that each value of opt and xllc has the same limitation of mllvm: only one option is allowed. I removed the new llvmopt and llvmllc, and modified the option explanation for opt and xllc. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the very clear text in the options, with examples. That should be a model for future options!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Jenkins Linux amd64 Build #15721 [push] Handle the options passe... started at 12:13 |
Jenkins Linux s390x Build #15724 [push] Handle the options passe... started at 13:13 |
Jenkins Linux ppc64le Build #14751 [push] Handle the options passe... started at 13:24 |
Jenkins Linux amd64 Build #15721 [push] Handle the options passe... passed after 1 hr 13 min |
Jenkins Linux s390x Build #15724 [push] Handle the options passe... passed after 1 hr 41 min |
Jenkins Linux ppc64le Build #14751 [push] Handle the options passe... passed after 2 hr 22 min |
Issue #2950 discovered the issue in passing options llvm. There are several problems:
I tested with some examples.