Verify minimum supported numpy in Windows Release CI #4279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
jcwchen
added
CI pipelines
Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
liqunfu
approved these changes
Jun 15, 2022
jcwchen
changed the title
Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
… jcw/mini-numpy
jcwchen
changed the title
Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
jcwchen
changed the title
broune
pushed a commit
to broune/onnx
that referenced
this pull request
May 6, 2023
* Verify minimum supported numpy in CIs Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * remove typo Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * keep windows and revert others Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * mention in doc Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Verify minimum supported numpy in Windows CI. Only apply it in Windows since numpy 1.16.6 does not support Python>=3.9 so we need to build numpy from source in CIs, which is time-consuming and it might bump into some issue unrelated to ONNX. For now verifying it in Windows CI should be sufficient.
Motivation and Context
Since ONNX's requirements.txt has loose restriction for NumPy (1.16.6) and it uses NumPy (1.21.5) for release. To prevent issues with older NumPy version (>=1.16.6; <1.21.5), CI should verify the built wheel can work with the minimum supported numpy. For instance, #4277 numpy.typing was introduced by NumPy 1.20. The failure with lower numpy version is not caught by any CI.