-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test lower protoc version in Linux CI #4365
Conversation
Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
…o jcw/mini-protoc Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> # Conflicts: # .github/workflows/manylinux/entrypoint.sh
Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
…o jcw/mini-protoc
One important change I would like to highlight is that this PR makes released ONNX wheel for Linux and Mac start to use It's possible that Linux users use older protoc versions (e.g., 3.0.0) from apt-get. Although using prebuilt wheel should be a fine case, to be safe, I tested the ONNX Linux wheel, which was built with |
Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
* use apt-get's libprotobuf-dev Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * change order Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * use Git instead of opeartor[] Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * use index Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * -DONNX_USE_PROTOBUF_SHARED_LIBS=ON Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * shape_inference test as well Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * test onnx_lite in GitHub Action instead Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * remove duplicate pip install Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * fix warnings in script Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * fix the rest of warnings Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * update docment Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * use $4 instead Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * use sh instead of shell Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * use $1 Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * failed_wheels Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * add doc Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * missing $1 Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * use $4 Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * use original Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * onnx_lite does not work with old protoc version Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * make Mac use ONNX_USE_LITE_PROTO to sync options for all envs Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * update CI doc to reflect recent changes Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
Description
Motivation and Context
For now there is no CI in ONNX testing lower protoc version. For instance, using libprotobuf-dev and protobuf-compiler from apt-get. ONNX mention this usage in the document and ideally the CI should cover this case.