Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Fix conversion of XGBoost model after being restored #506

Closed
wants to merge 6 commits into from

Conversation

xadupre
Copy link
Collaborator

@xadupre xadupre commented Oct 5, 2021

Investigate issue #499.

Signed-off-by: xavier dupré <xavier.dupre@gmail.com>
@xadupre xadupre added the bug Something isn't working label Oct 5, 2021
@BowenBao
Copy link
Contributor

BowenBao commented Nov 8, 2021

Hi @xadupre is the PR ready to be merged?

@xadupre
Copy link
Collaborator Author

xadupre commented Nov 9, 2021

No, the bug is still here. When the model is unpickled, xgboost does not restore exactly the same object and the converter does not find one attribute it is using.

@BowenBao
Copy link
Contributor

BowenBao commented Nov 9, 2021

No, the bug is still here. When the model is unpickled, xgboost does not restore exactly the same object and the converter does not find one attribute it is using.

Thanks, I can help take a look.

xadupre added 4 commits August 1, 2023 10:42
Signed-off-by: Xavier Dupre <xadupre@microsoft.com>
This reverts commit 8275f83.
Signed-off-by: Xavier Dupre <xadupre@microsoft.com>
@xadupre xadupre closed this Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants