Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: external infoview improvements #24

Merged
merged 5 commits into from
Oct 19, 2024
Merged

feat: external infoview improvements #24

merged 5 commits into from
Oct 19, 2024

Conversation

onriv
Copy link
Owner

@onriv onriv commented Oct 16, 2024

Some refactor, making the contract cleaner, and dynamic loading for widgets support, check here and here

Copy link

github-actions bot commented Oct 16, 2024

Qodana Community for JVM

188 new problems were found

Inspection name Severity Problems
Unused symbol 🔶 Warning 46
Redundant semicolon 🔶 Warning 29
Unused import directive 🔶 Warning 28
Unstable API Usage 🔶 Warning 19
Redundant nullable return type 🔶 Warning 4
Local 'var' is never modified and can be declared as 'val' 🔶 Warning 3
Constructor parameter is never used as a property 🔶 Warning 2
Usage of redundant or deprecated syntax or deprecated symbols 🔶 Warning 2
Redundant string template 🔶 Warning 2
Unresolved reference in KDoc 🔶 Warning 1
'catch' block may ignore exception 🔶 Warning 1
Redundant diagnostic suppression 🔶 Warning 1
Obvious explicit type 🔶 Warning 1
Redundant 'suspend' modifier 🔶 Warning 1
Redundant visibility modifier 🔶 Warning 1
Unused receiver parameter 🔶 Warning 1
Class member can have 'private' visibility ◽️ Notice 28
Accessor call that can be replaced with property access syntax ◽️ Notice 6
Unnecessary '@OptIn' annotation ◽️ Notice 3
Class naming convention ◽️ Notice 2
Redundant curly braces in string template ◽️ Notice 2
Negated call can be simplified ◽️ Notice 2
Return or assignment can be lifted out ◽️ Notice 1
Private property naming convention ◽️ Notice 1
Redundant 'if' statement ◽️ Notice 1

💡 Qodana analysis was run in the pull request mode: only the changed files were checked

View the detailed Qodana report

To be able to view the detailed Qodana report, you can either:

To get *.log files or any other Qodana artifacts, run the action with upload-result option set to true,
so that the action will upload the files as the job artifacts:

      - name: 'Qodana Scan'
        uses: JetBrains/qodana-action@v2024.2.3
        with:
          upload-result: true
Contact Qodana team

Contact us at qodana-support@jetbrains.com

@onriv onriv merged commit 711fbaf into main Oct 19, 2024
5 checks passed
@onriv onriv deleted the feat/infoview branch October 22, 2024 05:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant