Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changelog update - v0.1.4 #53

Merged
merged 1 commit into from
Nov 11, 2024

Changelog update - v0.1.4

461a78e
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

Changelog update - v0.1.4 #53

Changelog update - v0.1.4
461a78e
Select commit
Loading
Failed to load commit list.
GitHub Actions / Qodana Community for JVM completed Nov 11, 2024 in 0s

254 new problems found by Qodana Community for JVM

Qodana Community for JVM

254 new problems were found

Inspection name Severity Problems
Redundant semicolon 🔶 Warning 44
Unused symbol 🔶 Warning 41
Unused import directive 🔶 Warning 32
Unstable API Usage 🔶 Warning 25
Local 'var' is never modified and can be declared as 'val' 🔶 Warning 3
Constructor parameter is never used as a property 🔶 Warning 2
Redundant nullable return type 🔶 Warning 2
Redundant string template 🔶 Warning 2
Control flow with empty body 🔶 Warning 1
Incorrect string capitalization 🔶 Warning 1
Unresolved reference in KDoc 🔶 Warning 1
'catch' block may ignore exception 🔶 Warning 1
Usage of redundant or deprecated syntax or deprecated symbols 🔶 Warning 1
Redundant diagnostic suppression 🔶 Warning 1
Obvious explicit type 🔶 Warning 1
Redundant 'suspend' modifier 🔶 Warning 1
Redundant visibility modifier 🔶 Warning 1
Unused receiver parameter 🔶 Warning 1
Class member can have 'private' visibility ◽️ Notice 43
Property naming convention ◽️ Notice 16
Local variable naming convention ◽️ Notice 7
Accessor call that can be replaced with property access syntax ◽️ Notice 6
Nested lambda has shadowed implicit parameter ◽️ Notice 4
Return or assignment can be lifted out ◽️ Notice 3
Unnecessary '@OptIn' annotation ◽️ Notice 3
Class naming convention ◽️ Notice 2
Redundant 'if' statement ◽️ Notice 2
Redundant curly braces in string template ◽️ Notice 2
Unnecessary type argument ◽️ Notice 2
Negated call can be simplified ◽️ Notice 2
Private property naming convention ◽️ Notice 1

💡 Qodana analysis was run in the pull request mode: only the changed files were checked

View the detailed Qodana report

To be able to view the detailed Qodana report, you can either:

To get *.log files or any other Qodana artifacts, run the action with upload-result option set to true,
so that the action will upload the files as the job artifacts:

      - name: 'Qodana Scan'
        uses: JetBrains/qodana-action@v2024.2.5
        with:
          upload-result: true
Contact Qodana team

Contact us at qodana-support@jetbrains.com

Details

This result was published with Qodana GitHub Action

Annotations

Check warning on line 8 in src/main/kotlin/lean4ij/project/listeners/LeanFileEditorManagerListener.kt

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

Constructor parameter is never used as a property

Constructor parameter is never used as a property

Check warning on line 17 in src/main/kotlin/lean4ij/project/listeners/LeanFileCaretListener.kt

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

Constructor parameter is never used as a property

Constructor parameter is never used as a property

Check warning on line 143 in src/main/kotlin/lean4ij/infoview/LeanInfoViewWindowFactory.kt

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

Local 'var' is never modified and can be declared as 'val'

Variable is never modified, so it can be declared using 'val'

Check warning on line 351 in src/main/kotlin/lean4ij/language/InlayHints.kt

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

Local 'var' is never modified and can be declared as 'val'

Variable is never modified, so it can be declared using 'val'

Check warning on line 201 in src/main/kotlin/lean4ij/infoview/InfoviewPopupDocumentation.kt

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

Local 'var' is never modified and can be declared as 'val'

Variable is never modified, so it can be declared using 'val'

Check notice on line 11 in src/main/kotlin/lean4ij/project/leanFileProgressFinishedFillingLineMarkerRender.kt

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

Class naming convention

Class name `leanFileProgressFinishedFillingLineMarkerRender` should start with an uppercase letter

Check notice on line 10 in src/main/kotlin/lean4ij/project/leanFileProgressFillingLineMarkerRender.kt

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

Class naming convention

Class name `leanFileProgressFillingLineMarkerRender` should start with an uppercase letter

Check warning on line 25 in src/main/kotlin/lean4ij/language/Lean4ManualCompletionContributor.kt

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

Control flow with empty body

'if' has empty body

Check warning on line 101 in src/main/kotlin/lean4ij/setting/Lean4Settings.kt

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

Incorrect string capitalization

String '[ref](https://github.com/leanprover/lean4/tree/master/src/Lean/Server#in-general)' is not properly capitalized. It should have sentence capitalization

Check warning on line 97 in src/main/kotlin/lean4ij/lsp/LeanLanguageServer.kt

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

Unresolved reference in KDoc

Cannot resolve symbol 'CodeWithInfos'

Check warning on line 125 in src/main/kotlin/lean4ij/project/LeanFile.kt

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

'catch' block may ignore exception

Empty catch block

Check warning on line 233 in src/main/kotlin/lean4ij/infoview/external/Route.kt

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

Usage of redundant or deprecated syntax or deprecated symbols

Unnecessary non-null assertion (!!) on a non-null receiver of type JsonElement

Check warning on line 129 in src/main/kotlin/lean4ij/infoview/external/Route.kt

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

Redundant diagnostic suppression

Redundant suppression

Check warning on line 9 in src/main/kotlin/lean4ij/language/Lean4ParserDefinition.kt

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

Unused import directive

Unused import directive

Check warning on line 6 in src/main/kotlin/lean4ij/language/Lean4ParserDefinition.kt

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

Unused import directive

Unused import directive

Check warning on line 3 in src/main/kotlin/lean4ij/lsp/data/InteractiveTermGoal.kt

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

Unused import directive

Unused import directive

Check warning on line 10 in src/main/kotlin/lean4ij/infoview/LeanInfoViewWindowFactory.kt

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

Unused import directive

Unused import directive

Check warning on line 5 in src/main/kotlin/lean4ij/project/BuildWindowService.kt

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

Unused import directive

Unused import directive

Check warning on line 14 in src/main/kotlin/lean4ij/project/listeners/LeanFileCaretListener.kt

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

Unused import directive

Unused import directive

Check warning on line 8 in src/main/kotlin/lean4ij/language/Lean4ParserDefinition.kt

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

Unused import directive

Unused import directive

Check warning on line 4 in src/main/kotlin/lean4ij/infoview/external/JcefInfoviewTooWindowFactory.kt

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

Unused import directive

Unused import directive

Check warning on line 9 in src/main/kotlin/lean4ij/infoview/InfoviewPopupDocumentation.kt

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

Unused import directive

Unused import directive

Check warning on line 11 in src/main/kotlin/lean4ij/language/Lean4ManualCompletionContributor.kt

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

Unused import directive

Unused import directive

Check warning on line 10 in src/main/kotlin/lean4ij/language/Lean4ParserDefinition.kt

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

Unused import directive

Unused import directive

Check warning on line 9 in src/main/kotlin/lean4ij/infoview/LeanInfoViewWindow.kt

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

Unused import directive

Unused import directive