fix incorrect role in imdi if the Actor doesn't have an actual lameta…

… person

package.json

@@ -2,7 +2,7 @@
   "main": "dist/src/mainProcess/main.js",
   "name": "lameta",
   "productName": "lameta",
-  "version": "2.3.14-beta",
+  "version": "2.3.15-beta",
   "author": {
     "name": "lameta",
     "email": "sorryno@email.org"

src/export/ImdiGenerator.ts

@@ -160,7 +160,7 @@ export default class ImdiGenerator {
       } else {
         this.startGroup("Actor");
         this.tail.comment(`Could not find a person with name "${trimmedName}"`);
-        this.element("Role", contribution.role);
+        this.element("Role", this.getRoleOutput(contribution.role));
         this.element("Name", trimmedName);
         this.element("FullName", trimmedName);
         this.element("Code", "");
@@ -773,6 +773,16 @@ export default class ImdiGenerator {
     //}
   }
 
+  private getRoleOutput(role: string): string {
+    let roleOutput = "Unspecified";
+    if (role && role.length > 0) {
+      // replace underscores with spaces
+      roleOutput = role.replace(/_/g, " ");
+      // upper case the first letter of the first word only (per ELAR's Hanna)
+      roleOutput = roleOutput.charAt(0).toUpperCase() + roleOutput.slice(1);
+    }
+    return roleOutput;
+  }
   // See https://tla.mpi.nl/wp-content/uploads/2012/06/IMDI_MetaData_3.0.4.pdf for details
   public actor(
     person: Person,
@@ -781,13 +791,7 @@ export default class ImdiGenerator {
     moreKeys?: any[]
   ): string | null {
     return this.group("Actor", () => {
-      let roleOutput = "Unspecified";
-      if (role && role.length > 0) {
-        // replace underscores with spaces
-        roleOutput = role.replace(/_/g, " ");
-        // upper case the first letter of the first word only (per ELAR's Hanna)
-        roleOutput = roleOutput.charAt(0).toUpperCase() + roleOutput.slice(1);
-      }
+      const roleOutput = this.getRoleOutput(role);
 
       this.element("Role", roleOutput);
       this.requiredField("Name", "name", person);

src/export/sessionImdi-custom.spec.ts

@@ -21,7 +21,7 @@ beforeAll(async () => {
   session = project.addSession();
   // set the session date to a known value so that the test results are predictable
 
-  session.addFileForTestAsync(randomFileName());
+  await session.addFileForTestAsync(randomFileName());
   const mary = project.addPerson("Mary");
   mary.properties.setText("birthYear", "1980");
 });
@@ -95,6 +95,24 @@ describe("session imdi export", () => {
     expect("//Actor/Role").toHaveText("Careful speech speaker"); // this is ELAR's prefered case and spacing
   });
 
+  // Regression Test
+  it("A contribution from a person with a missing Person should still be output correct role", () => {
+    session.removeAllContributionsForUnitTest();
+    session.addContribution(
+      new Contribution("I am made up", "careful_speech_speaker", "")
+    );
+    setResultXml(
+      ImdiGenerator.generateSession(
+        IMDIMode.RAW_IMDI,
+        session,
+        project,
+        true /*omit namespace*/
+      )
+    );
+    expect("//Actor").toHaveCount(1);
+    expect("//Actor/Role").toHaveText("Careful speech speaker"); // this is ELAR's prefered case and spacing
+  });
+
   /* the actual policy is in discussion in Notion #238
 
   It's not clear what we will do, but at the moment, we're output a minimal Actor