Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GinkoT().Error[f]: record error instead of aborting the test #1331

Closed
pohly opened this issue Jan 5, 2024 · 2 comments
Closed

GinkoT().Error[f]: record error instead of aborting the test #1331

pohly opened this issue Jan 5, 2024 · 2 comments
Assignees

Comments

@pohly
Copy link
Contributor

pohly commented Jan 5, 2024

Ginkgo is built around the assumption that all failed assertions are fatal, i.e. testing must stop. This has the effect that GinkgoT().Error and GinkgoT().Errorf behave like GinkgoT().Fatal[f].

It would be nice to support the normal testing.T semantic and not abort the test.

Alternatively (or perhaps as a interim solution) this limitation should at least get documented.

@onsi
Copy link
Owner

onsi commented Jan 17, 2024

I'll document it - but don't have plans to change the behavior of Fail().

@pohly
Copy link
Contributor Author

pohly commented Jan 17, 2024

Fail shouldn't change. It's GinkgoT().Error error which is currently a bit odd. But not changing it is fine.

@onsi onsi self-assigned this Jan 17, 2024
@onsi onsi closed this as completed Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants