Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ginkgo dryRun outputs "slow tests" #436

Closed
nodo opened this issue Mar 2, 2018 · 0 comments
Closed

Ginkgo dryRun outputs "slow tests" #436

nodo opened this issue Mar 2, 2018 · 0 comments

Comments

@nodo
Copy link
Collaborator

nodo commented Mar 2, 2018

When running ginkgo with the -dryRun flag, it wrongly warns the user about slow tests.

For instance using this test:

var _ = Describe("Playground", func() {
	It("succeeds", func() {
		Expect(1).To(Equal(1))
	})
})

It outputs the following:

$> ginkgo -dryRun .
Running Suite: Playground Suite
===============================
Random Seed: 1519999176
Will run 1 of 1 specs

• [SLOW TEST:9223372036.855 seconds]
Playground
/Users/pivotal/go/src/github.com/nodo/playground/playground/playground_test.go:8
  succeeds
  /Users/pivotal/go/src/github.com/nodo/playground/playground/playground_test.go:9
------------------------------

Ran 1 of 1 Specs in 0.000 seconds
SUCCESS! -- 0 Passed | 0 Failed | 0 Pending | 0 Skipped PASS

Ginkgo ran 1 suite in 612.596828ms
Test Suite Passed

Note that the test took 612ms to run, but the warns says it took 9223372036.855 seconds. We would expect to not see the warning.

with @kirederik

@nodo nodo assigned nodo and unassigned nodo Mar 6, 2018
@MirahImage MirahImage self-assigned this Mar 6, 2018
kirederik added a commit that referenced this issue Mar 12, 2018
Do not set the run time of a spec when the dryRun flag is used

Solves #436
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants