-
-
Notifications
You must be signed in to change notification settings - Fork 650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Call ReportAfterSuite in --dry-run mode #935
Comments
iirc i turned this off intentionally. your usecase makes sense to me though so let me dig into why i'd done that and circle back. |
I've been able to find a way around the change by setting Seems to be working OK so far, but a modified |
Makes sense - but I think I agree that the intent behind |
it'll be in the next release - not sure yet when I'll cut a release, though. hopefully in the next few days/week. |
The spec will be added back in the future, here is just a workaround for now. ref: onsi/ginkgo#935 Signed-off-by: Dave Chen <dave.chen@arm.com>
I've been running ginkgo in
--dry-run
mode to generate a custom report of all the tests in my project without having to run them (it's a long-running integration test suite)After migrating to Ginkgo v2 I notice that
ReportAfterSuite()
isn't called when--dry-run
is enabled, I think because of this block - https://github.com/onsi/ginkgo/blob/master/internal/suite.go#L528-L530:The same occurs with
ReportAfterEach()
Would you consider changing the behaviour so that the reporting hooks are called even in dry-run mode?
The text was updated successfully, but these errors were encountered: