-
-
Notifications
You must be signed in to change notification settings - Fork 650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix hang with ginkgo -p #1192
Merged
Merged
fix hang with ginkgo -p #1192
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
ffd0055
integration: build interceptor binary automatically
Luap99 d51a0a2
integration: make interceptor test parallel safe
Luap99 a5c22da
fix hang with ginkgo -p
Luap99 037445a
Rearrange new interceptor hang tests and confirm they cover the issue…
onsi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,60 @@ | ||
# Backlog | ||
[] @G fix hang with ginkgo -p | ||
https://github.com/onsi/ginkgo/issues/1192 | ||
[] @B biloba needs to support "McDonald's" | ||
[] @G Document order of execution for setup nodes on the same level | ||
https://github.com/onsi/ginkgo/issues/1172 | ||
[] @G fail fast may cause Serial spec or cleanup Node interrupted | ||
https://github.com/onsi/ginkgo/issues/1178 | ||
|
||
# Needs-Prioritization | ||
[] @G Pull JUnit config out of code and into flags/config files | ||
https://github.com/onsi/ginkgo/issues/1115 | ||
[] @G -exec support for `ginkgo run` | ||
https://github.com/onsi/ginkgo/issues/869 | ||
[] @G Add `indent` to gcustom | ||
[] @G HaveField should not panic in FailureMessage if the field is non-existant. It should return a meaningful failure message. | ||
[] @G allow NodeTimeout and GracePeriod to live on containers and propagate down | ||
[] @G Clean up ReportEntry decoding: | ||
func (entry ReportEntry) DecodeValue(p interface{}) error { | ||
// if raw is assignable to p, assign | ||
// else - parse AsJSON | ||
} | ||
[] @B Biloba lets you get all innerHTML and emit it on failure | ||
[] @B equivalent of puppeteer text selector? | ||
[] @B how do we invoke async functions? what does await look like for those? maybe time to actually read? goal: remove the separate muhasibPostLogin function. | ||
[] @B https://github.com/onsi/biloba/issues/2 | ||
[] @B right now polling an element fails if the browser if ollowing redirects. so i'm using Eventually(b.Location) - instead of just Eventually("#el").Should(b.Exist()). I think we need a more robust way to ensure biloba. | ||
[] @B biloba support for gettign "SelectedOption" instead of just "Value" for select inputs (e.g. b.OptionByName(...) instead of value?) | ||
[] @B ginkgo interrupt should not show the whole stacktrace. it's just too much! | ||
[] @B add cookie support | ||
chromedp.Run(b.Context, chromedp.ActionFunc(func(ctx context.Context) error { | ||
return storage.ClearDataForOrigin("*", "all").Do(ctx) | ||
})) | ||
|
||
chromedp.Run(b.Context, chromedp.ActionFunc(func(ctx context.Context) error { | ||
expr := cdp.TimeSinceEpoch(time.Date(2091, 28, 3, 1, 40, 45, 0, time.UTC)) | ||
return storage.SetCookies([]*network.CookieParam{{ | ||
Name: "rallly-session", | ||
Value: "Fe26.2*1*66a5cae1dd8728fc7be37a1a3c485557606e526b16b472329be78168ad4d48c2*Yb_O9pN2K3APF6LXt9S3zg*IZQ_c5aukJzt-AIW__lL19igVhpFMGH9cK0PyFenF-2ti94BgBsLDf325DB2rsKE*3825906104968*a06f3cfe6ef65db1a30b5177cb767c914ca38c8fc3e2456de89d5bea5641611e*6HNCfDeEzgfeQO88IRJ8TfdG5IDzDQtt6WaoGAg5i98~2", Expires: &expr, | ||
Domain: "rallly.co", | ||
Path: "/", | ||
HTTPOnly: true, | ||
Secure: true, | ||
SameSite: network.CookieSameSiteLax, | ||
}}).WithBrowserContextID(b.BrowserContextID()).Do(ctx) | ||
})) | ||
[] @Ω Gomega should have an error returning mode, then tell pohly | ||
[] @Ω Gomega submatcher description interface and bare-element interface (the former for any sort of matcher that takes a submatcher; the latter specifically for matchers like Consistently etc. that would replace equalMatchersToElements. | ||
|
||
|
||
[] @B JSSelector (is a function that returns one or many nodes) | ||
[] @B ScrollTo etc. | ||
[] @B support for esbuild? or something? consider the auth_login_scripts tests - what might make them better? | ||
|
||
# Long-term Backlog | ||
- VSCode Extension | ||
- Ginkgo WebView | ||
- Suite configuration | ||
- Suite parallelization | ||
- With the special subcase of supporting shared singleton resources |
25 changes: 25 additions & 0 deletions
25
integration/_fixtures/interceptor_sleep_fixture/interceptor_fixture_suite_test.go
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
package main_test | ||
|
||
import ( | ||
"fmt" | ||
"os" | ||
"os/exec" | ||
"testing" | ||
|
||
. "github.com/onsi/ginkgo/v2" | ||
. "github.com/onsi/gomega" | ||
) | ||
|
||
func TestInterceptorSleepFixture(t *testing.T) { | ||
RegisterFailHandler(Fail) | ||
RunSpecs(t, "TestInterceptorSleepFixture Suite") | ||
} | ||
|
||
var _ = Describe("Ensuring that ginkgo -p does not hang when output is intercepted", func() { | ||
It("ginkgo -p should not hang on this spec", func() { | ||
fmt.Fprintln(os.Stdout, "Some STDOUT output") | ||
fmt.Fprintln(os.Stderr, "Some STDERR output") | ||
cmd := exec.Command("sleep", "60") | ||
Ω(cmd.Start()).Should(Succeed()) | ||
}) | ||
}) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for merging, did you intent to commit the TODO file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no, sigh - i had just renamed it and updated my .gitignore on main but accidentally committed it in the pr. i've cleaned it up now, though it will live on forever in the git history. there's nothing sensitive in there