Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warn when a suite has test files but no tests to run #345

Merged
merged 1 commit into from
Apr 18, 2017
Merged

Warn when a suite has test files but no tests to run #345

merged 1 commit into from
Apr 18, 2017

Conversation

benmoss
Copy link
Contributor

@benmoss benmoss commented Apr 18, 2017

#344

Feel free to kibbitz this, I was kinda unsure where to put this / if making a MultiWriter for stderr was the right way to go.

@benmoss
Copy link
Contributor Author

benmoss commented Apr 18, 2017

Also unclear if this what I/you had in mind:

netherland:ginkgo-repro pivotal$ ginkgo
PASS
testing: warning: no tests to run
Found no test suites, did you forget to run "ginkgo bootstrap"?
Ginkgo ran 1 suite in 482.469569ms
Test Suite Failed

@onsi
Copy link
Owner

onsi commented Apr 18, 2017

LGTM!

@onsi onsi merged commit b1d624c into onsi:master Apr 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@benmoss @onsi