-
-
Notifications
You must be signed in to change notification settings - Fork 650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow coverage to be displayed for focused specs #367
Allow coverage to be displayed for focused specs #367
Conversation
"time" | ||
|
||
"io/ioutil" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
goimports
doing its thing. I'm happy to revert these lines if you'd prefer...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no problem :)
I'd ask for the environment variable to be slightly more generic. Perhaps just EDITOR_INTEGRATION=true This will make it easier to get into vim-go as I don't think they want to special case ginkgo. |
This is a very ginkgo specific thing. I would imagine a non-specific variable like I actually thought I might need to be even more specific (e.g. |
i don't feel too strongly about what to call the env variable - perhaps get input from the vim-go maintainers? @joefitzgerald can you add an integration test under |
@onsi Integration test added. |
Sweet thanks! |
In #205, there was lamentation! Show coverage for focused specs, we could not 😢. With this PR, it is possible to opt-in to allow coverage to be shown for focused specs.
The default behavior (failing the suite if any focusing is present, to prevent it from getting through CI) is preserved. A savvy editor integrator can transparently set the
GINKGO_EDITOR_INTEGRATION
environment variable to some non-empty value (e.g.true
) to suppress the197
exit code, and allow a coverage file to be generated (and thus allow coverage to be displayed in the editor).