-
-
Notifications
You must be signed in to change notification settings - Fork 650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a When() synonym for Context() #386
Conversation
Thanks for the PR @akshaymankar I'm gonna tag this as |
Would you be open to rebasing off master and repushing so we can get coverage on 1.9 now that our Travis configuration runs against it? I ran your branch locally on 1.9.1 and it failed, but if I rebased off master tests passed. |
I like this functionality! In my mind, |
Good to see this PR getting some traction. I've been looking forward to seeing it get merged since I use |
@lflux Thanks for the review. I will rebase the branch in my flex-hour or over the weekend. I couldn't find a place to add tests for dsl code. If you could point me to it, I'll add tests for the functions related to I am not sure why should |
I don't really want this merged because it opens the door to DSL bloat for all the conjunctions e.g. Pragmatically though, I understand that people are interested in this and there is some precedent for Seems like instead of doing:
we could do:
In the same way Due to my admittedly flimsy reasons at the top, I'd also prefer not to see all the Finally, definitely want some docs to be PRed along with this to the TL;DR: Changes I'd like:
But I'm happy to chat about any/all of these! Thanks. |
I am not so sure about the DSL bloat problem. Right now it is not such a big problem, but if it does start bloating maybe that can be a separate project. My views/comments on the requested changes:
I already have a problem with the Specify works. Whenever I have a failure, ginkgo tells me the failure is in ginkgo's code where Specify is defined. As somebody who has seen his tests red, I wouldn't want ginkgo's line numbers in my report.
I agree with the arguments given. I will revert changes to the tests and add another test.
I will write it up and send another PR. |
@akshaymankar I didn't realise
->
Totally agree with you if that is what happens though. If you have a reproduction, we can open a separate issue to fix it. Thanks. |
@williammartin Third line in the output that you posted:
It usually prints the line where |
Didn't see that you'd updated this PR, sorry! Happy to merge now. Two outstanding things we can follow up on after is updating the docs, and writing a test, maybe within the Thanks |
Solves #348