Imports in generated code should follow conventions #398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinxsliu
force-pushed
the
generated-import-ordering
branch
2 times, most recently
from
b43eb6a
to
3317374
Compare
martinxsliu
force-pushed
the
generated-import-ordering
branch
from
3317374
to
0bec0b0
Compare
|
LGTM thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #396
This PR changes the ordering of the imports in the code generated by
ginkgo bootstrapandginkgo generateto follow Go conventions of grouping by standard library imports, then 3rd party imports, then by local imports.This PR also removes a superfluous
_testfrom the package name generated byginkgo generate -agouti.