Synchronise the access to the state of specs to avoid race conditions #430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #426 Signed-off-by: Ed Cook <ecook@pivotal.io> Signed-off-by: Giuseppe Capizzi <gcapizzi@pivotal.io>
|
LGTM but is there any way to get any test coverage out of this? |
|
Thanks @williammartin. We were discussing it, it would be fairly easy to add an integration test for that. However, we were not sure about the value of this. A possibility could be to add an integration test that:
Do you think that something like this would be good? |
|
@williammartin I have done a couple of tests with the idea above. The test looks a bit flakey to me and I wouldn't add it. Is that OK for you to merge the PR as it is? |
|
Yeh alright, just wanted to check to be sure. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #426.
/cc @gcapizzi @edwardecook