Also process FSpecify when unfocusing #434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh neat, any chance I can persuade you to add |
|
@williammartin with pleasure :) |
integration/subcommand_test.go
Outdated
| @@ -345,7 +345,7 @@ var _ = Describe("Subcommand", func() { | |||
| }) | |||
| }) | |||
|
|
|||
| Describe("ginkgo blur", func() { | |||
| FDescribe("ginkgo blur", func() { | |||
There was a problem hiding this comment.
Uh oh, looks like this focus is breaking the Travis build!
There was a problem hiding this comment.
Rha. Sorry, too hasty there.
|
LGTM thanks, will merge when the build passes :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #433.
This adds
FSpecifyto the list of unfocus components, with a hopefully appropriate test.I took the liberty to cast the tested output to strings, so failures are more readable (Go otherwise prints the output as a slice of bytes).