Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail fast when the outputdir of combined coverage profile does not exist #446

Merged
merged 2 commits into from
Apr 6, 2018

Commits on Apr 5, 2018

  1. Fail fast when the outputdir of combined coverage profile does not exist

    This is a workaround for a change in behaviour between go <= 1.9 and go
    1.10.
    
    Prior to go 1.9, compiling a test would not fail if the specified
    output dir does not exist. However, it does fail in go 1.10.
    
    By failing when the the directory does not exist, we have a consistent
    behaviour withing go versions.
    
    See also golang/go#24588
    Andrea Nodari committed Apr 5, 2018
    Configuration menu
    Copy the full SHA
    c0b857d View commit details
    Browse the repository at this point in the history

Commits on Apr 6, 2018

  1. Update CHANGELOG.md

    Mention the breaking change when `-coverprofile` and `-outputdir`
    flags are set, but the directory does not exist.
    Andrea Nodari committed Apr 6, 2018
    Configuration menu
    Copy the full SHA
    a37f4c0 View commit details
    Browse the repository at this point in the history