Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JUnit: include more detailed information about panic #519

Merged
merged 1 commit into from
Jul 21, 2019

Conversation

pohly
Copy link
Contributor

@pohly pohly commented Sep 11, 2018

When a test aborts with a panic, the generic information ("Test
Panicked", single source line) is not enough. We also better include
the error that was handed to panic() and a full stacktrace to
determine the root cause.

@pohly
Copy link
Contributor Author

pohly commented Sep 11, 2018

I'm getting a test failure also without this PR:

[Fail] Flags Specs [It] should run the race detector when told to 
/nvme/gopath/src/github.com/onsi/ginkgo/integration/flags_test.go:110

@pohly
Copy link
Contributor Author

pohly commented Sep 11, 2018

The https://travis-ci.org/onsi/ginkgo/builds/427319025?utm_source=github_status&utm_medium=notification test run failed because gopkg.in seems to be down (parse https://gopkg.in/yaml.v2?go-get=1: no go-import meta tags) - I just saw that same error in a Kubernetes CI run.

@nodo
Copy link
Collaborator

nodo commented Sep 17, 2018

I have restarted the build, let's see if it becomes green.

@nodo
Copy link
Collaborator

nodo commented Sep 17, 2018

@pohly do you think you would be able to add a test for the new functionality?

@pohly
Copy link
Contributor Author

pohly commented Sep 17, 2018 via email

@nodo
Copy link
Collaborator

nodo commented Sep 18, 2018

Sure no worries @pohly. Feel free to ping me if you need help.

When a test aborts with a panic, the generic information ("Test
Panicked", single source line) is not enough. We also better include
the error that was handed to panic() and a full stacktrace to
determine the root cause.
@pohly
Copy link
Contributor Author

pohly commented Oct 30, 2018

@node finally got around to extending the tests. I hope this is what you had in mind.

@williammartin
Copy link
Collaborator

@nodo Can you review? It seems like you last had context.

@pohly
Copy link
Contributor Author

pohly commented Jul 15, 2019

@nodo ping

@nodo
Copy link
Collaborator

nodo commented Jul 21, 2019

Thanks @pohly ! Looks good to me 👍

@nodo nodo merged commit 19cca4b into onsi:master Jul 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants