Add Helper() method to GinkgoTInterface

[bstick12]

• This aligns more with the testing.TB interface

This has been requested in

• GinkgoT() should implements testing.TB #582
• Add "Helper()" to GinkgoTInterface #563.

I was also looking for the functionality to use https://github.com/cloudfoundry/libcfbuildpack

[williammartin]

I'm not totally sure about this. There is an expectation from tests is that Helper() results in some behaviour around error reporting similar to ExpectWithOffset. That said, we have an equivalent that does nothing in Parallel().

I'd be inclined to merge to help people out but I could imagine it causing confusion in the future.

What do you think @blgm @ansd ?

[jmalloc]

Even if Helper() was a no-op, I too would find this very useful from an integration standpoint.

[jjaferson]

Hey guys,

Any idea whether this PR is going to get merged?

it would be nice to have GinkgoTInterface compatible with testing.TB even if Helper() is a no-op

[blgm]

Hi @jjaferson. It looks like this has already been implemented in commit b5fe44d

Ideally this PR would have been closed before, but since the code has already been merged in another PR, I don't think there's much value in keeping it around. Please let me know if there's something I missed.

[jjaferson]

@blgm thanks, I was using an old version of GinkGo I noticed it's been added in 1.14.2.