Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add _internal to filename of tests created with internal flag #751

Merged
merged 1 commit into from
Dec 12, 2020
Merged

Add _internal to filename of tests created with internal flag #751

merged 1 commit into from
Dec 12, 2020

Conversation

kevinkirkup
Copy link
Contributor

Fixes #750

@onsi
Copy link
Owner

onsi commented Dec 12, 2020

also looks good - though it seems the entire -internal flag is not covered by the integration tests. I'll fix that after I pull this PR in and your other one as well.

@onsi onsi merged commit 43c12da into onsi:master Dec 12, 2020
@kevinkirkup kevinkirkup deleted the feature/Issue750_Add_internal_to_output_name branch December 12, 2020 20:37
This was referenced Mar 8, 2021
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Merged
Merged
This was referenced Mar 16, 2021
Merged
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Mar 17, 2021
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Merged
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Generate internal should use add "_internal" to the test name
2 participants
@kevinkirkup @onsi