internal/remote: use unix.Dup2 instead of wrapping Dup2/Dup3 manually #761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest version of the golang.org/x/sys/unix package already implements func Dup2 using Dup3 on platforms which dont have the dup2 syscall. Use Dup2 and let x/sys/unix figure out the correct syscall. This effectivly reverts PR onsi#680. Verified that ginkgo still correctly builds on linux/mips64le.
|
sweet! thank you :) this cleans things up nicely. |
This was referenced Mar 8, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest version of the golang.org/x/sys/unix package already
implements func Dup2 using Dup3 on platforms which dont have the dup2
syscall. Use Dup2 and let x/sys/unix figure out the correct syscall.
This effectivly reverts PR #680. Verified that ginkgo still correctly
builds on linux/mips64le.