-
-
Notifications
You must be signed in to change notification settings - Fork 650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add slim-sprig template functions to bootstrap/generate #775
Add slim-sprig template functions to bootstrap/generate #775
Conversation
thanks @hagaibarel - this makes sense and looks simple enough. my only hesitation is that Sprig is pulling in a lot of additional dependencies. is there a similar library that is a little more lightweight? as you consider your usecase are you needing all of Sprig or simply a subset? to say a bit more - i know ginkgo is in use in a number of production systems and pipelines where security is a major concern. growing ginkgo's dependency graph adds that much more to the security burden across those systems. |
I can understand and respect that, dependency chains can be an issue. I'm not familiar with other |
@onsi any thoughts on this? |
I can't speak for @onsi, but I was wondering how hard it would be to make this a plugin? It could solve the dependency issue by making it optional, and it could allow folks to use alternative templating languages in the future without having to make a code change. Perhaps an optional flag for the
This idea might be completely impractical in this case (I don't see a |
thanks for the bump @hagaibarel - I agree, @blgm a more decoupled approach would be ideal. If that isn't feasible, slim-sprig definitely looks better from a dependencies POV and I'm ok pulling it in. |
I think the idea of Anyways @onsi I've switched to |
Fixes #774