-
-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add HaveExactElements matcher #634
Conversation
I wanted to implement some mechanism of reporting the matching failure.
I'm thinking of utilizing the matcher messages used to fail the elements, but don't want to have the newlines. Thanks! 😄 |
616c9d6
to
2dd80dc
Compare
hey! sorry for the delay - thanks for pulling this together. i'll take a look tomorrow and share feedback/pull it in. for now - it looks like one of the tests failed on ci? |
Ok - took a look and this looks good to me. i don't think it's gonna be super easy to generically remove the new lines in the responses - but I think it's fine to err on the verbose side:
|
2dd80dc
to
fde2203
Compare
fde2203
to
29c0d68
Compare
Hi, sorry for the late response. I have updated the implementation on the test reporting. |
Looks great, thanks - I'll merge this in after the tests go green. Would you be up for adding a brief snippet of documentation to docs/index.md ? Fine if not, I can do it after I pull it in. Thanks! |
done! 😁 |
This is the PR for implementing the ordered matcher.
Closes #622