Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

issue_765 - fixed bug in Hopcroft-Karp algorithm #766

Merged
merged 1 commit into from
Jul 25, 2024
Merged

issue_765 - fixed bug in Hopcroft-Karp algorithm #766

merged 1 commit into from
Jul 25, 2024

Conversation

timmyb32r
Copy link
Contributor

see #765

@onsi
Copy link
Owner

onsi commented Jun 19, 2024

hi - thanks for digging into this and providing a fix. sorry for the delay but i'm going to need to find some time to understand this and pull it in (and rewrite the test into a ginkgo test to match the other tests in the package). hope to get to it in the next few weeks.

@onsi onsi merged commit ebadb67 into onsi:master Jul 25, 2024
@onsi
Copy link
Owner

onsi commented Jul 25, 2024

thanks! I've pulled this in and updated the tests to match the existing test style

@gibizer
Copy link
Contributor

gibizer commented Jul 29, 2024 •
edited

Hi! This patch seems to be causing issue with golang 1.20 due to slices is not in 1.20 only from 1.21

When bumping to gomega 1.34.0 I see:

/home/gibi/go/pkg/mod/github.com/onsi/gomega@v1.34.0/matchers/support/goraph/bipartitegraph/bipartitegraphmatching.go:4:2: package slices is not in GOROOT (/usr/lib/go-1.20/src/slices)

See a public bump failure in openstack-k8s-operators/nova-operator#837 (comment)

@gibizer gibizer mentioned this pull request Jul 29, 2024
Closed
gibizer added a commit to gibizer/gomega that referenced this pull request Jul 29, 2024
@gibizer
Use slices from exp/slices to keep golang 1.20 compat
8f581f6 
The onsi#766 introduced dependency to slices but that module is not in the
standard lib in golang 1.20.

Closes: onsi#774
@gibizer gibizer mentioned this pull request Jul 29, 2024
Merged
onsi pushed a commit that referenced this pull request Jul 29, 2024
@gibizer @onsi
Use slices from exp/slices to keep golang 1.20 compat
5e71dcd 
The #766 introduced dependency to slices but that module is not in the
standard lib in golang 1.20.

Closes: #774
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@timmyb32r @onsi @gibizer