Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] housenumber wrongly placed. #237

Closed
farfromrefug opened this issue May 29, 2022 · 1 comment · Fixed by #241
Closed

[BUG] housenumber wrongly placed. #237

farfromrefug opened this issue May 29, 2022 · 1 comment · Fixed by #241
Labels
bug Something isn't working

Comments

@farfromrefug
Copy link
Contributor

This is osm
Screenshot 2022-05-29 at 17 28 53

This is omt
Screenshot 2022-05-29 at 17 25 32

This is PT
Screenshot 2022-05-29 at 17 25 48

As you can see the housenumber is wrongly place in PT . And you actually end up not knowing on which side of the building it should be. I understand why it is there because of centroidIfConvex.
@farfromrefug farfromrefug added the bug Something isn't working label May 29, 2022
@msbarry
Copy link
Contributor

msbarry commented May 30, 2022

Thanks for pointing this out - looks like isConvex is actually returning a result for isConcave. I'll put out a quick fix for it.

@msbarry msbarry mentioned this issue May 30, 2022
Merged
@erik erik mentioned this issue Jan 26, 2023
Merged
@msbarry msbarry mentioned this issue Jan 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix is convex negated onthegomap/planetiler
2 participants
@farfromrefug @msbarry