-
-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "fix is convex negated (#241)" #458
Conversation
This reverts commit f93e522.
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
https://github.com/onthegomap/planetiler/actions/runs/4011478453 ℹ️ Base Logs ae1317c
ℹ️ This Branch Logs ef1f4af
|
OK so reverting this is correct, but the root cause of #237 is this line that omits any triangles where the area < 1e-10: planetiler/planetiler-core/src/main/java/com/onthegomap/planetiler/geo/GeoUtils.java Lines 451 to 455 in a0f8c67
Since we fit the entire planet into 0->1 coordinates, the minimum threshold should be more like 1e-20 to cut of anything less than ~1 square inch. Want to make that in this PR or separate? |
IMO let's keep the changes separate. I think ideally it's at least somewhat zoom dependent, since you might care a lot about a polygon being concave by a meter for a building, but for a country it doesn't matter at all |
This reverts commit f93e522.
The original name of this function was correct, it was returning
true
when given a convex polygon andfalse
given a concave polygon. This is confirmed by the test cases inGeoUtilsTest
.The issue described in #237 is likely still present, perhaps due to failing when given self intersecting polygons.
Some more context in this slack thread