-
-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check disk space and memory only with OSM input file #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://github.com/onthegomap/planetiler/actions/runs/1991650973 ℹ️ Base Logs 0a06479
ℹ️ This Branch Logs 7017030
|
I am happy to share an example how to render a custom shapefile with planetiler once this issue and #137 are solved. |
Oops, good catch! This sounds good - for most other non-OSM sources, there should be very little memory/disk requirements besides the intermediate features and output size. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
checkDiskSpace()
andcheckMemory()
estimate resouce requirements based on an OSM input file.Currently, if no OSM input file is present, e.g., because only a shapefile input is used, Planetiler crashes complaining about the absence of a OSM input file for the resource checks.
With this pull request, the resource checks only run if an OSM file is present.