-
-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README.md #140
Update README.md #140
Conversation
Fix "planetilerler" typo on "java" line. Nudge non-Java people into adding methods inside their new class, not outside it.
If someone can translate "The following files had format violations:" into English I'd be happy to resolve... |
Thanks for helping improve the docs! Yikes it looks like we had a couple of CI flake-outs here. I re-ran some so they should be fixed now.
We just added auto-formatting for java and markdown files, I think it's just complaining about the trailing whitespace at the end of line 59 - if you remove that it should be fine, I could also disable the check on markdown files as it doesn't help as much as with Java. Also for what it's worth, we're going to be exploring some options for config or script-driven style definitions in the near future (see #81) so while you need to write Java code right now to add new styles, you eventually won't need to. |
https://github.com/onthegomap/planetiler/actions/runs/2019479927 ℹ️ Base Logs 313a695
ℹ️ This Branch Logs 8f5720f
|
Removed space at end of line 59
Thank you @SomeoneElseOSM ! |
Fix "planetilerler" typo on "java" line.
Nudge non-Java people into adding methods inside their new class, not outside it.