-
-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose setId in FeatureCollector [#377] #514
Conversation
https://github.com/onthegomap/planetiler/actions/runs/4421596644 ℹ️ Base Logs d5b404d
ℹ️ This Branch Logs c7085f9
|
public Feature setSourceId(long sourceId) { | ||
this.sourceId = sourceId; | ||
return this; | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's change this to setId
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we deprecate getSourceId
and add getId
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could just leave them separate and have setId
getId
and getSourceId
since they are technically different concepts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
where you usually interact with FeatureCollector
you also have access to the sourceFeature
, right? so might be redundant to have a getSourceId
that delegates to the FeatureCollector
's source
when you can call source.id()
ptal |
Kudos, SonarCloud Quality Gate passed! |
To aid in setting OSM IDs in #377