-
-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Overture maps downloads. #599
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://github.com/onthegomap/planetiler/actions/runs/5213129549 ℹ️ Base Logs f8c0d46
ℹ️ This Branch Logs e728c44
|
msbarry
reviewed
Jun 8, 2023
planetiler-core/src/main/java/com/onthegomap/planetiler/util/AwsOsm.java
Outdated
Show resolved
Hide resolved
Nice! Thanks for the fix. Looks like we lucked out that the osm-pds filename patterns are very similar to the overture ones, and sorting the names will give you the latest one but we could parameterize those in the future if we need to for another source. |
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Conveniently we can reuse the existing
AwsOsm
class here, just pointing to a different S3 bucket.There's only one release at the moment, so it's unclear if we'll need more filtering in the future (to exclude pre-release versions, for example).
Implements #552.