-
-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replaced log4j usage with commons-io #777
Conversation
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
https://github.com/onthegomap/planetiler/actions/runs/7445802382 ℹ️ Base Logs c480b35
ℹ️ This Branch Logs deeb6e0
|
ya, I would definitely do that and not pull in another dependency just for that. I just made use of |
Closing due to #777 (comment) |
See #773 (reply in thread)
This is a separate PR since it's introducing a new dependency which is certainly more controversial then #776 - especially since it's only used for one method.
The same goal is probably also reachable by returning an anonymous inline extension of some sort OutputStream wich just overwrites the
close
method...