-
-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filter out null MultiExpression entries #822
Merged
msbarry
merged 1 commit into
onthegomap:main
from
phanecak-maptiler:skip_osm_read_when_no_layer_needs_it
Feb 29, 2024
Merged
Filter out null MultiExpression entries #822
msbarry
merged 1 commit into
onthegomap:main
from
phanecak-maptiler:skip_osm_read_when_no_layer_needs_it
Feb 29, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quality Gate passedIssues Measures |
phanecak-maptiler
changed the title
filter out null MultiExpression entries
Filter out null MultiExpression entries
Feb 28, 2024
https://github.com/onthegomap/planetiler/actions/runs/8082465391 ℹ️ Base Logs d703b62
ℹ️ This Branch Logs 566f746
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… allowing skipping of OSM read when no profile needs OSM data. See openmaptiles/planetiler-openmaptiles#156 for how to handle that in a custom profile (but that PR was closed without merging since OpenMapTiles profile actually uses OSM in all layers hence the change there is not effective).
E.g. if we run for example
java ... --only-layers=water ...
Planetiler skips OSM processing since such data is not needed forwater
layer, thus speeding up work when one is troubleshooting only that one particular layer.Fixes #823 .