Merge pull request #1196 from ontodev/cmungall-patch-2

Fix docs on missing_subset_declaration.rq
ontodev · May 1, 2024 · 4aebac4 · 4aebac4
2 parents dc04a3c + f2cc8d6
commit 4aebac4
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/docs/report_queries/missing_subset_declaration.md b/docs/report_queries/missing_subset_declaration.md
@@ -1,6 +1,6 @@
 # Missing Subset Declaration
 
-**Problem:** A subset is used in an annotation, but is not properly declared as a child of oboInOwl:SubsetProperty. This can cause problems with conversions to OBO format.
+**Problem:** A subset is used in an annotation (via oboInOwl:inSubset), but is not properly declared as a child of oboInOwl:SubsetProperty. This can cause problems with conversions to OBO format, and should be avoided as all subsets should have metadata.
 
 **Solution:** Make the subset a child of oboInOwl:SubsetProperty.
 
@@ -14,4 +14,4 @@ SELECT DISTINCT ?entity ?property ?value WHERE {
     FILTER NOT EXISTS { ?entity ?property oboInOwl:SubsetProperty }
 }
 ORDER BY ?entity
-```
+```
diff --git a/robot-core/src/main/resources/report_queries/missing_subset_declaration.rq b/robot-core/src/main/resources/report_queries/missing_subset_declaration.rq
@@ -1,8 +1,8 @@
 # # Missing Subset Declaration
 #
-# **Problem:** A synonym type is used in an annotation, but is not properly declared as a child of oboInOwl:SynonymTypeProperty. This can cause problems with conversions to OBO format.
+# **Problem:** A subset is used in an annotation (via oboInOwl:inSubset), but is not properly declared as a child of oboInOwl:SubsetProperty. This can cause problems with conversions to OBO format, and should be avoided as all subsets should have metadata.
 #
-# **Solution:** Make the synonym type a child of oboInOwl:SubsetProperty.
+# **Solution:** Make the subset a child of oboInOwl:SubsetProperty.
 
 PREFIX rdfs: <http://www.w3.org/2000/01/rdf-schema#>
 PREFIX oboInOwl: <http://www.geneontology.org/formats/oboInOwl#>
@@ -12,4 +12,4 @@ SELECT DISTINCT ?entity ?property ?value WHERE {
     ?x oboInOwl:inSubset ?entity .
     FILTER NOT EXISTS { ?entity ?property oboInOwl:SubsetProperty }
 }
-ORDER BY ?entity
+ORDER BY ?entity