Fixing the invalid xref check #1186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I just updated the tests to illustrates that the new check works. |
anitacaron
approved these changes
Apr 17, 2024
matentzn
added a commit
to monarch-initiative/mondo
that referenced
this pull request
Apr 22, 2024
twhetzel
pushed a commit
to monarch-initiative/mondo
that referenced
this pull request
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1127
docs/have been added/updatedmvn verifysays all tests passmvn sitesays all JavaDocs correctCHANGELOG.mdhas been updatedThis PR fixing the regular expression used to recognise XREFs. I tested it in the https://regex101.com/ sandbox:
^[A-Za-z_]: Starts with an alphabet letter (either uppercase or lowercase) or an underscore.[A-Za-z0-9_.-]*: Followed by any number (including zero) of alphanumeric characters, underscores, periods, or hyphens.[A-Za-z0-9_]: Ends the first part with an alphanumeric character or an underscore.:: Contains a colon separating the prefix from the reference.[^\\s]+$: Matches the reference, which comprises 1 or more characters that are not whitespace (including spaces, tabs, and newlines).