Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend RelatedObjectsHelper.getAxiomSubjects() to missing property axiom types #1187

Merged
merged 8 commits into from
May 1, 2024
Merged

Extend RelatedObjectsHelper.getAxiomSubjects() to missing property axiom types #1187

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
e9bc206
Add Object property characteristics, inverses, domains, ranges to bas…
matentzn Mar 10, 2024
c2f0dd2
Reflect changes in domain axioms
matentzn Mar 10, 2024
c7da1a9
Fix another test
matentzn Mar 10, 2024
d2ec7a0
Update template-drop-axiom-remove.owl
matentzn Mar 10, 2024
ba3f8ea
Update template-base.owl
matentzn Mar 10, 2024
001f94a
Add subannotation property to getSubject()
matentzn Mar 10, 2024
1cdebfe
Update CHANGELOG.md
matentzn Mar 10, 2024
663a25f
Merge branch 'master' into issue1108-characteristicsmissingfrombase
jamesaoverton May 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Handle IRIs that are not entities in export [#1168]
- Fix integration tests [#1181]
- Invalid Xrefs test has been fixed to recognise invalid CURIEs correctly [#1127]
- Fix issue with correctly determining base entities [#1108]

## [1.9.5] - 2023-09-20

Expand Down Expand Up @@ -399,7 +400,9 @@ First official release of ROBOT!
[#1152]: https://github.com/ontodev/robot/issues/1152
[#1148]: https://github.com/ontodev/robot/pull/1148
[#1135]: https://github.com/ontodev/robot/pull/1135
[#1127]: https://github.com/ontodev/robot/pull/1127
[#1119]: https://github.com/ontodev/robot/pull/1119
[#1108]: https://github.com/ontodev/robot/pull/1108
[#1104]: https://github.com/ontodev/robot/pull/1104
[#1100]: https://github.com/ontodev/robot/pull/1100
[#1091]: https://github.com/ontodev/robot/issues/1091
Expand Down
9 changes: 9 additions & 0 deletions docs/examples/template-base-filter.owl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,15 @@
<obo:IAO_0000115 rdf:datatype="http://www.w3.org/2001/XMLSchema#string">Weight of a mouse or rat in kilograms (kg).</obo:IAO_0000115>
<obo:IAO_0000117 rdf:datatype="http://www.w3.org/2001/XMLSchema#string">Rebecca C Jackson</obo:IAO_0000117>
<rdfs:label rdf:datatype="http://www.w3.org/2001/XMLSchema#string">weight in kilograms</rdfs:label>
<rdfs:domain>
<owl:Class>
<owl:unionOf rdf:parseType="Collection">
<rdf:Description rdf:about="http://example.com/B6C3F1"/>
<rdf:Description rdf:about="http://example.com/F344N"/>
</owl:unionOf>
</owl:Class>
</rdfs:domain>
<rdfs:range rdf:resource="http://www.w3.org/2001/XMLSchema#decimal"/>
</owl:DatatypeProperty>
<owl:Axiom>
<owl:annotatedSource rdf:resource="http://example.com/propery-1"/>
Expand Down
9 changes: 9 additions & 0 deletions docs/examples/template-base.owl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,15 @@
<obo:IAO_0000115 rdf:datatype="http://www.w3.org/2001/XMLSchema#string">Weight of a mouse or rat in kilograms (kg).</obo:IAO_0000115>
<obo:IAO_0000117 rdf:datatype="http://www.w3.org/2001/XMLSchema#string">Rebecca C Jackson</obo:IAO_0000117>
<rdfs:label rdf:datatype="http://www.w3.org/2001/XMLSchema#string">weight in kilograms</rdfs:label>
<rdfs:domain>
<owl:Class>
<owl:unionOf rdf:parseType="Collection">
<rdf:Description rdf:about="http://example.com/B6C3F1"/>
<rdf:Description rdf:about="http://example.com/F344N"/>
</owl:unionOf>
</owl:Class>
</rdfs:domain>
<rdfs:range rdf:resource="http://www.w3.org/2001/XMLSchema#decimal"/>
</owl:DatatypeProperty>
<owl:Axiom>
<owl:annotatedSource rdf:resource="http://example.com/propery-1"/>
Expand Down
11 changes: 10 additions & 1 deletion docs/examples/template-drop-axiom-filter.owl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,15 @@
<obo:IAO_0000115 rdf:datatype="http://www.w3.org/2001/XMLSchema#string">Weight of a mouse or rat in kilograms (kg).</obo:IAO_0000115>
<obo:IAO_0000117 rdf:datatype="http://www.w3.org/2001/XMLSchema#string">Rebecca C Jackson</obo:IAO_0000117>
<rdfs:label rdf:datatype="http://www.w3.org/2001/XMLSchema#string">weight in kilograms</rdfs:label>
<rdfs:domain>
<owl:Class>
<owl:unionOf rdf:parseType="Collection">
<rdf:Description rdf:about="http://example.com/B6C3F1"/>
<rdf:Description rdf:about="http://example.com/F344N"/>
</owl:unionOf>
</owl:Class>
</rdfs:domain>
<rdfs:range rdf:resource="http://www.w3.org/2001/XMLSchema#decimal"/>
</owl:DatatypeProperty>


Expand Down Expand Up @@ -126,5 +135,5 @@



<!-- Generated by the OWL API (version 4.5.6) https://github.com/owlcs/owlapi -->
<!-- Generated by the OWL API (version 4.5.26) https://github.com/owlcs/owlapi -->

9 changes: 9 additions & 0 deletions docs/examples/template-drop-axiom-remove.owl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,15 @@
<obo:IAO_0000115 rdf:datatype="http://www.w3.org/2001/XMLSchema#string">Weight of a mouse or rat in kilograms (kg).</obo:IAO_0000115>
<obo:IAO_0000117 rdf:datatype="http://www.w3.org/2001/XMLSchema#string">Rebecca C Jackson</obo:IAO_0000117>
<rdfs:label rdf:datatype="http://www.w3.org/2001/XMLSchema#string">weight in kilograms</rdfs:label>
<rdfs:domain>
<owl:Class>
<owl:unionOf rdf:parseType="Collection">
<rdf:Description rdf:about="http://example.com/B6C3F1"/>
<rdf:Description rdf:about="http://example.com/F344N"/>
</owl:unionOf>
</owl:Class>
</rdfs:domain>
<rdfs:range rdf:resource="http://www.w3.org/2001/XMLSchema#decimal"/>
</owl:DatatypeProperty>


Expand Down
56 changes: 56 additions & 0 deletions robot-core/src/main/java/org/obolibrary/robot/RelatedObjectsHelper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1417,6 +1417,14 @@ private static Set<IRI> getAxiomSubjects(OWLAxiom axiom) {
} else {
iris.addAll(getIRIsFromEntities(subject.getSignature()));
}
} else if (axiom instanceof OWLSubAnnotationPropertyOfAxiom) {
OWLSubAnnotationPropertyOfAxiom spAxiom = (OWLSubAnnotationPropertyOfAxiom) axiom;
OWLAnnotationProperty subject = spAxiom.getSubProperty();
if (!subject.isAnonymous()) {
return Sets.newHashSet(subject.asOWLAnnotationProperty().getIRI());
} else {
iris.addAll(getIRIsFromEntities(subject.getSignature()));
}
} else if (axiom instanceof OWLEquivalentDataPropertiesAxiom) {
OWLEquivalentDataPropertiesAxiom eqAxiom = (OWLEquivalentDataPropertiesAxiom) axiom;
for (OWLSubDataPropertyOfAxiom spAxiom : eqAxiom.asSubDataPropertyOfAxioms()) {
Expand Down Expand Up @@ -1492,6 +1500,54 @@ private static Set<IRI> getAxiomSubjects(OWLAxiom axiom) {
for (OWLObjectPropertyExpression expr : spcAxiom.getPropertyChain()) {
iris.addAll(getIRIsFromEntities(expr.getSignature()));
}
} else if (axiom instanceof OWLObjectPropertyCharacteristicAxiom) {
OWLObjectPropertyCharacteristicAxiom chAxiom = (OWLObjectPropertyCharacteristicAxiom) axiom;
OWLObjectPropertyExpression subject = chAxiom.getProperty();
if (!subject.isAnonymous()) {
return Sets.newHashSet(subject.asOWLObjectProperty().getIRI());
} else {
iris.addAll(getIRIsFromEntities(subject.getSignature()));
}
} else if (axiom instanceof OWLObjectPropertyDomainAxiom) {
OWLObjectPropertyDomainAxiom domainAxiom = (OWLObjectPropertyDomainAxiom) axiom;
OWLObjectPropertyExpression subject = domainAxiom.getProperty();
if (!subject.isAnonymous()) {
return Sets.newHashSet(subject.asOWLObjectProperty().getIRI());
} else {
iris.addAll(getIRIsFromEntities(subject.getSignature()));
}
} else if (axiom instanceof OWLObjectPropertyRangeAxiom) {
OWLObjectPropertyRangeAxiom rangeAxiom = (OWLObjectPropertyRangeAxiom) axiom;
OWLObjectPropertyExpression subject = rangeAxiom.getProperty();
if (!subject.isAnonymous()) {
return Sets.newHashSet(subject.asOWLObjectProperty().getIRI());
} else {
iris.addAll(getIRIsFromEntities(subject.getSignature()));
}
} else if (axiom instanceof OWLDataPropertyDomainAxiom) {
OWLDataPropertyDomainAxiom domainAxiom = (OWLDataPropertyDomainAxiom) axiom;
OWLDataPropertyExpression subject = domainAxiom.getProperty();
if (!subject.isAnonymous()) {
return Sets.newHashSet(subject.asOWLDataProperty().getIRI());
} else {
iris.addAll(getIRIsFromEntities(subject.getSignature()));
}
} else if (axiom instanceof OWLDataPropertyRangeAxiom) {
OWLDataPropertyRangeAxiom rangeAxiom = (OWLDataPropertyRangeAxiom) axiom;
OWLDataPropertyExpression subject = rangeAxiom.getProperty();
if (!subject.isAnonymous()) {
return Sets.newHashSet(subject.asOWLDataProperty().getIRI());
} else {
iris.addAll(getIRIsFromEntities(subject.getSignature()));
}
} else if (axiom instanceof OWLInverseObjectPropertiesAxiom) {
OWLInverseObjectPropertiesAxiom iopAxiom = (OWLInverseObjectPropertiesAxiom) axiom;
OWLObjectPropertyExpression subject = iopAxiom.getFirstProperty();
if (!subject.isAnonymous()) {
return Sets.newHashSet(subject.asOWLObjectProperty().getIRI());
} else {
iris.addAll(getIRIsFromEntities(subject.getSignature()));
}
} else {
logger.warn("Axiom type not supported: " + axiom.getClass().toString());
}
Expand Down
Loading